Skip to content
This repository has been archived by the owner on Sep 27, 2020. It is now read-only.

Update S99custom #370

Open
wants to merge 1 commit into
base: rb-4.1.X
Choose a base branch
from
Open

Update S99custom #370

wants to merge 1 commit into from

Conversation

air-sky-one
Copy link

Please make sure your PR is ready to be merged !

  • You added the changes in CHANGELOG.md
  • You choose the right repository branch to make the PR
  • You described the PR as below

Fixes #XXXX

Changes :

  • just modify the script to be more respectful of best practices

Related to (put here the others PR in other repositories)

  • not to my knowledge

Make the script more beautiful. With a great thanks to Substring for his help

Make the script more beautiful. With a great thanks to Substring for his help
@digitalLumberjack
Copy link
Member

I like the usage of the log file, but the copy of $1 in param only for the values start and stop seems unecessary (and keep the script of behing used with other values for param (e.g. restart etc)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants